Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ECMAScript 14 to boa_tester #3273

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Add ECMAScript 14 to boa_tester #3273

merged 3 commits into from
Sep 13, 2023

Conversation

jedel1043
Copy link
Member

@jedel1043 jedel1043 commented Sep 12, 2023 •
edited
Loading

Depends on #3274.

This needs to be merged after the conformance webpage PR is merged, which I'll link here when I finish it which is linked above.

@jedel1043 jedel1043 added enhancement New feature or request test Issues and PRs related to the tests. labels Sep 12, 2023
@jedel1043 jedel1043 added this to the v0.18.0 milestone Sep 12, 2023
@jedel1043 jedel1043 mentioned this pull request Sep 13, 2023
Merged
@jedel1043 jedel1043 changed the base branch from dependabot/submodules/test262-1db9a49 to main September 13, 2023 01:01
@jedel1043 jedel1043 marked this pull request as ready for review September 13, 2023 01:02
@jedel1043 jedel1043 requested a review from a team September 13, 2023 01:02
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,410 95,410 0
Passed 75,078 75,078 0
Ignored 19,342 19,342 0
Failed 990 990 0
Panics 0 0 0
Conformance 78.69% 78.69% 0.00%

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (7aaa35e) 50.33% compared to head (8e40d99) 50.30%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3273      +/-   ##
==========================================
- Coverage   50.33%   50.30%   -0.04%     
==========================================
  Files         436      436              
  Lines       42625    42656      +31     
==========================================
  Hits        21456    21456              
- Misses      21169    21200      +31
Files Changed Coverage Δ
boa_tester/src/edition.rs 0.00% <0.00%> (ø)
boa_tester/src/main.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

HalidOdat
HalidOdat approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

nekevss
nekevss approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@jedel1043 jedel1043 added this pull request to the merge queue Sep 13, 2023
Merged via the queue into main with commit 36d1ca9 Sep 13, 2023
@jedel1043 jedel1043 deleted the es14-update branch September 13, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekevss nekevss nekevss approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request test Issues and PRs related to the tests.
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jedel1043 @HalidOdat @nekevss